Skip to content

Conversation

@rohan-chaturvedi
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi commented Feb 27, 2024

🔍 Overview

Creating a new secret in the console often requires manually revealing the value to see what is typed / pasted. This gets particularly annoying when creating multiple secrets.

💡 Proposed Changes

Reveal the value when creating a new secret. Mask it once changes are saved.

Fixes #193

🖼️ Screenshots or Demo

Screencast.from.02-27-2024.11.52.38.AM.webm

📝 Release Notes

Automatically reveal secret value when creating a new secret

❓ Open Questions

Should this be a workspace / Organisation level setting in the future? Some users may prefer the original behavior, particularly if working in public, screen sharing etc.

✨ How to Test the Changes Locally

  • Create a secret
  • Observe that the value is automatically revealed
  • Observe that the value is automatically masked once the secret is saved on the server

💚 Did You...

  • Ensure linting passes (code style checks)?
    - [ ] Update dependencies and lockfiles (if required)
  • Verify the app builds locally?
  • Manually test the changes on different browsers/devices?

@nimish-ks
Copy link
Member

🙏🏻

@nimish-ks
Copy link
Member

Small thing: Automatically focus on the secret key field after clicking ➕ New Secret button, so the user can type the key name straight away without highlighting the text input by manually clicking on it.

Screencast.from.2024-02-27.13-32-03.webm

@rohan-chaturvedi
Copy link
Member Author

Small thing: Automatically focus on the secret key field after clicking ➕ New Secret button, so the user can type the key name straight away without highlighting the text input by manually clicking on it.
Screencast.from.2024-02-27.13-32-03.webm

Good call. Done

@nimish-ks nimish-ks merged commit 6930ffe into main Feb 28, 2024
@nimish-ks nimish-ks deleted the feat--reveal-new-secret branch February 28, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncover value when a new secret is created

3 participants