Skip to content

Conversation

@rohan-chaturvedi
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi commented Aug 4, 2025

💡 Proposed Changes

  • Use more robust parsing of route params, rather than splitting the pathname string
  • Add breadcrumbs for all available page routes
  • Add programmatic page titles

🖼️ Screenshots or Demo

image image image image image

🎯 Reviewer Focus

Verify that the breadcrumbs and page titles are correct for all page routes (app and org pages)

💚 Did You...

  • Ensure linting passes (code style checks)?
    - [ ] Update dependencies and lockfiles (if required)
    - [ ] Update migrations (if required)
    - [ ] Regenerate graphql schema and types (if required)
  • Verify the app builds locally?
  • Manually test the changes on different browsers/devices?

Note

Adds centralized route parsing and breadcrumb/page-title utilities, refactors NavBar to use them, and updates onboarding/team layouts accordingly.

  • Navigation:
    • Refactor components/layout/Navbar.tsx to a client component using useParsedRoute, generateBreadcrumbs, and generatePageTitle; renders dynamic breadcrumbs and updates document.title; removes team prop.
    • Add utils/navigation.ts with generateBreadcrumbs and generatePageTitle supporting team and non-team routes.
    • Add utils/route.ts (useParsedRoute) to robustly parse route segments.
    • Update app/[team]/layout.tsx to render <NavBar /> without props.
    • Update components/layout/OnboardingNavbar.tsx to set page titles for non-team routes via generatePageTitle.
  • Utilities:
    • Add isUUID in utils/copy.ts; minor JSDoc/type tweaks.

Written by Cursor Bugbot for commit 7a52743. This will update automatically on new commits. Configure here.

@rohan-chaturvedi rohan-chaturvedi added enhancement New feature or request frontend Change in frontend code labels Aug 4, 2025
nimish-ks
nimish-ks previously approved these changes Aug 30, 2025
@nimish-ks
Copy link
Member

@cursor review

cursor[bot]

This comment was marked as outdated.

Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
…eration

Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors navigation breadcrumbs and page titles to use more robust route parsing and adds comprehensive breadcrumb generation for all page routes. The changes improve the user experience by providing clear navigation context and programmatic page titles.

  • Replace pathname string splitting with structured route parameter parsing
  • Add comprehensive breadcrumb generation logic for all app and organization routes
  • Implement programmatic page title generation based on navigation context

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
frontend/utils/route.ts New utility for robust route parameter parsing using Next.js hooks
frontend/utils/navigation.ts New utility for generating breadcrumbs and page titles from navigation context
frontend/utils/copy.ts Added UUID validation utility and fixed JSDoc parameter types
frontend/components/layout/Navbar.tsx Refactored to use new navigation utilities and removed team prop dependency
frontend/app/webauth/[requestCode]/page.tsx Code formatting improvements for better readability
frontend/app/[team]/layout.tsx Removed team prop from NavBar component usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rohan-chaturvedi
Copy link
Member Author

@cursor review

@cursor
Copy link

cursor bot commented Oct 6, 2025

Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository.

Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
@nimish-ks
Copy link
Member

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


@nimish-ks
Copy link
Member

Beautiful.

@nimish-ks nimish-ks merged commit bd8e452 into main Oct 6, 2025
8 checks passed
@nimish-ks nimish-ks deleted the feat--better-titles branch October 6, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Change in frontend code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants