-
Notifications
You must be signed in to change notification settings - Fork 53
refactor: improve breadcrumbs and page titles #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cursor review |
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
…eration Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors navigation breadcrumbs and page titles to use more robust route parsing and adds comprehensive breadcrumb generation for all page routes. The changes improve the user experience by providing clear navigation context and programmatic page titles.
- Replace pathname string splitting with structured route parameter parsing
- Add comprehensive breadcrumb generation logic for all app and organization routes
- Implement programmatic page title generation based on navigation context
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/utils/route.ts | New utility for robust route parameter parsing using Next.js hooks |
| frontend/utils/navigation.ts | New utility for generating breadcrumbs and page titles from navigation context |
| frontend/utils/copy.ts | Added UUID validation utility and fixed JSDoc parameter types |
| frontend/components/layout/Navbar.tsx | Refactored to use new navigation utilities and removed team prop dependency |
| frontend/app/webauth/[requestCode]/page.tsx | Code formatting improvements for better readability |
| frontend/app/[team]/layout.tsx | Removed team prop from NavBar component usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@cursor review |
|
Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository. |
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
|
Beautiful. |
💡 Proposed Changes
🖼️ Screenshots or Demo
🎯 Reviewer Focus
Verify that the breadcrumbs and page titles are correct for all page routes (app and org pages)
💚 Did You...
- [ ] Update dependencies and lockfiles (if required)- [ ] Update migrations (if required)- [ ] Regenerate graphql schema and types (if required)Note
Adds centralized route parsing and breadcrumb/page-title utilities, refactors
NavBarto use them, and updates onboarding/team layouts accordingly.components/layout/Navbar.tsxto a client component usinguseParsedRoute,generateBreadcrumbs, andgeneratePageTitle; renders dynamic breadcrumbs and updatesdocument.title; removesteamprop.utils/navigation.tswithgenerateBreadcrumbsandgeneratePageTitlesupporting team and non-team routes.utils/route.ts(useParsedRoute) to robustly parse route segments.app/[team]/layout.tsxto render<NavBar />without props.components/layout/OnboardingNavbar.tsxto set page titles for non-team routes viageneratePageTitle.isUUIDinutils/copy.ts; minor JSDoc/type tweaks.Written by Cursor Bugbot for commit 7a52743. This will update automatically on new commits. Configure here.