-
Notifications
You must be signed in to change notification settings - Fork 53
feat: vercel custom environment support #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the Vercel secret sync integration to support custom environments, moving from a simple string-based environment list to a structured environment object with proper metadata.
- Replaced hardcoded environment strings with dynamic environment objects containing ID, name, and slug
- Added support for Vercel custom environments through new API endpoints
- Updated GraphQL schema and queries to handle structured environment data
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/graphql/queries/syncing/vercel/getProject.gql | Updated GraphQL query to fetch structured environment objects instead of string array |
| frontend/components/syncing/Vercel/CreateVercelSync.tsx | Modified UI component to handle environment objects and use proper environment selection |
| frontend/apollo/schema.graphql | Added new VercelEnvironmentType schema definition |
| frontend/apollo/graphql.ts | Updated TypeScript types to match new schema |
| frontend/apollo/gql.ts | Updated generated GraphQL documents |
| backend/api/utils/syncing/vercel/main.py | Added custom environment support with new API endpoints and proper environment resolution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@cursor review |
β¦nent to save a click
|
Agreed, I'll make these changes |
β¦r 'all' environments and improved filtering Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
frontend/components/syncing/Vercel/CreateVercelSync.tsx:1
- Remove large block of commented-out code that has been replaced by the Combobox implementation.
import GetVercelProjects from '@/graphql/queries/syncing/vercel/getProject.gql'
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@cursor review |
1 similar comment
|
@cursor review |
β¦nments and sync_vercel_secrets functions Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
frontend/components/syncing/Vercel/CreateVercelSync.tsx:1
- Remove commented-out code instead of leaving it in the codebase. This reduces code clutter and maintainability issues.
import GetVercelProjects from '@/graphql/queries/syncing/vercel/getProject.gql'
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@cursor review |

π Overview
Extends the Vercel secret sync integration to support Custom Environments. Fixes #651
πΌοΈ Screenshots or Demo
π Did You...
- [ ] Update dependencies and lockfiles (if required)- [ ] Update migrations (if required)Note
Adds end-to-end support for Vercel custom environments, updating backend sync logic and frontend/UI to select and manage specific environments.
VercelEnvironmentTypeand replacesVercelProjectType.environmentwithenvironments(includes standard and custom envs).get_project_custom_environmentsand integrates intolist_vercel_projectsto return full env details (id,name,slug,type).get_existing_env_varsto match variables that exclusively target a specific environment (supportscustomEnvironmentIds).sync_vercel_secrets:alland custom slugs).all, syncs to each environment separately.target) vs custom (customEnvironmentIds) envs; handles update/delete per env.delete_env_varhelper.VercelEnvironmentType;VercelProjectType.environmentsreplacesenvironment.GetVercelProjectsquery to returnenvironments { id name slug type }.CreateVercelSync: replaces fixed env radio with environment picker from projectenvironments; sendsenvironmentas envslug.ManageSyncDialog: showsenvironment.nameinstead ofenvType.Written by Cursor Bugbot for commit e772e54. This will update automatically on new commits. Configure here.