fix: replace full_clean with clean in ServiceAccountToken save method #665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Overview
Fixed the ApolloError: {'expires_at': ['This field cannot be blank.']} when creating Service Account Tokens that do not expire.
💡 Proposed Changes
Replace the unnecessary
full_clean()call with justclean()on modelsave()to run our custom validation logic💚 Did You...
- [ ] Update dependencies and lockfiles (if required)- [ ] Update migrations (if required)- [ ] Regenerate graphql schema and types (if required)Note
Replace full_clean() with clean() in ServiceAccountToken.save to run custom validation only.
backend/api/models.py):ServiceAccountToken.saveto callclean()instead offull_clean().Written by Cursor Bugbot for commit c53c971. This will update automatically on new commits. Configure here.