Redis Deployment Not Created Due to Incorrect Conditional Logic in Helm Template

[jonaskonig]

Description:
The Redis deployment is not being created because the conditional logic in the Helm template is incorrect. The template checks for {{- if or (not .Values.global.external) (not .Values.redis.external) }}, but .Values.global.external does not exist in the values.yaml. Instead, the correct key is .Values.global.external.enabled.

Current Behavior:

• Redis deployment is not created, even when redis.external: false is set.
• The migrations and other components hang waiting for Redis, which never starts.

Expected Behavior:

• Redis deployment should be created when redis.external: false and global.external.enabled: false.

Root Cause:
The template uses:

{{- if or (not .Values.global.external) (not .Values.redis.external) }}

But the values.yaml defines:

global:
  external:
    enabled: false

The template should check .Values.global.external.enabled instead of .Values.global.external.

Proposed Fix:
Update the conditional in the Redis deployment template to:

{{- if or (not .Values.global.external.enabled) (not .Values.redis.external) }}

Additional Context:

• This issue prevents the chart from deploying Redis internally, causing all dependent components to hang.
• The fix is minimal and aligns the template with the actual values.yaml structure.

Steps to Reproduce:

1. Deploy the chart with redis.external: false and global.external.enabled: false.
2. Observe that no Redis pod is created.
3. Check the Helm template for the conditional logic.

[nimish-ks]

Hey @jonaskonig!

Thanks for making a detailed issue. This was also affecting the Postgrsql deployment, which now I have fixed in #32.

I have decided to go with a more streamlined approach which deprecates .Values.global.external.enabled entirely, so you can individually configure database and redis.

Lmk thoughts!