Skip to content

Conversation

@gloomystore
Copy link

What kind of change does this PR introduce?

  • Bugfix - fixes translation typo

Screenshots or Gifs of the change

Screenshot of translation
N/A — This is a small text change in a Korean translation string.

Does this PR introduce a breaking change?

  • No

Tests done

  • Manual check: Verified correct rendering of the updated translation string.
  • Confirmed placeholder order is now appropriate for Korean grammar.

Other information

This PR fixes a Korean translation error in the MULTIPLE_ERRORS string where the placeholder order was grammatically incorrect.
Changed:

"MULTIPLE_ERRORS": "{0} {1}개 문제 - {2}"
"MULTIPLE_ERRORS_FIXABLE": "{0} {1}개 문제, {2}개 수정 가능 - {3}"

To:

"MULTIPLE_ERRORS": "{1} {0}개 문제 - {2}"
"MULTIPLE_ERRORS_FIXABLE": "{1} {0}개 문제, {2}개 수정 가능 - {3}"

What Was Wrong:

"23 제이에스힌트개 문제 - index.js"

→ Interpreted like “Numbers of JSHint Problems 23 - index.js”

It Should Be:

"제이에스힌트 23개 문제 - index.js"

→ Now it reads naturally like “23 JSHint Problems - index.js”

Although it's a small fix, I hope it improves the experience for Korean users.

Since this is a simple translation correction, I did not open a separate issue.
Please let me know if you'd prefer one to track this change more formally 🙏

@sonarqubecloud
Copy link

@abose
Copy link
Member

abose commented Mar 27, 2025

Thanks for contributing @gloomystore
To clarify the licensing situation, we'd like to request your explicit permission to distribute the changes you've submitted in this pull request.

Can you do one of the following to help me merge this change?

  1. Sign the CLA at https://phcode-dev.github.io/contributor-license-agreement/ OR
  2. Just comment "I grant permission to distribute my contributions in this pull request under MIT License Terms."

@gloomystore
Copy link
Author

I grant permission to distribute my contributions in this pull request under MIT License Terms.

@abose abose merged commit c7ed968 into phcode-dev:main Mar 27, 2025
3 checks passed
@abose
Copy link
Member

abose commented Mar 27, 2025

LGTM merging. Thanks for contributing @gloomystore

@phcode-dev phcode-dev locked and limited conversation to collaborators Apr 26, 2025
@phcode-dev phcode-dev unlocked this conversation Apr 26, 2025
@phcode-dev phcode-dev locked and limited conversation to collaborators Apr 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants