Skip to content

Add "dont use this.send in componentWillUnmount" section to README #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2018
Merged

Add "dont use this.send in componentWillUnmount" section to README #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d378dcd
Add "dont use this.send in componentWillUnmount" section to README
vovacodes Aug 2, 2018
ecdb425
fix README formatting
vovacodes Aug 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ ReComponent comes with four different types of [effects](https://github.com/phil

By intelligently using any of the four types above, it is possible to transition between states in one place and without the need to use `setState()` manually. This drastically simplifies our mental model since changes must always go through the reducer first.

**NOTE!**
You should NEVER call `this.send` or any sender in **`componentWillUnmount`**.
If you need to execute a side-effect in **`componentWillUnmount`** (e.g. clear a timer) call that side-effect directly.

## FAQ

### Advantages Over `setState`
Expand Down