Fix #15 #18
Merged
Fix #15 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carbontwelve
commented
Mar 7, 2018
carbontwelve
commented
- Update minimum supported laravel version to 5.4 (it works below that for now but this is the minimum I want to support.)
- Fixed issue Exception with array fieldnames #15 array upload fields now supported
- Added unit tests for Exception with array fieldnames #15
carbontwelve
added a commit
that referenced
this pull request
Mar 14, 2018
* ✨ Support Auto-Discovery #10 (#11) * 📝 add build status * Fixes #15 (#18) * Failing test written as confirmation of issue #15 * added remembered file entity * construct from and export to UploadedFile * Compose with RememberedFile instead of array * Use Illuminate UploadedFile, this is for Laravel after all * working towards solving #15 * Memo to self * notes * Made much more DRY * Wrote testArrayFileUploadOldRemembered test * Added RememberedFileBag * Refactored to add functionality for issue #15 * Removed final inspection warning * Added failing test for checking validation errors invalidate array uploads * Update to support laravel 5.4 as a minimum * Fix unit test * Remove composer.lock this is a lib not a project * Replace Illuminate UploadedFile with Symfony UploadedFile * Test able to reproduce bug discovered by Jarosław Goszowski on issue #15 * Fixed * Amended documentation for #17 * Added configuration as per #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.