Skip to content

Fix when passing working dir #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Fix when passing working dir #19

merged 1 commit into from
Oct 27, 2020

Conversation

akira28
Copy link
Contributor

@akira28 akira28 commented Oct 26, 2020

No description provided.

@g105b
Copy link
Member

g105b commented Oct 27, 2020

@akira28 thank you so much for noticing this! I wonder if there is a way I can automate some tests to prevent this kind of typo being made in the future?

@g105b g105b merged commit 2cdd87f into php-actions:master Oct 27, 2020
@akira28 akira28 deleted the patch-1 branch October 27, 2020 14:01
@akira28
Copy link
Contributor Author

akira28 commented Oct 27, 2020

@akira28 thank you so much for noticing this! I wonder if there is a way I can automate some tests to prevent this kind of typo being made in the future?

I suppose there's something, but a simple search on Google wasn't helpful, as 'github actions testing' obviously return stuff related to 'run your unit tests with github actions'.

@g105b
Copy link
Member

g105b commented Oct 28, 2020

hmm, I'll give it some thought. Feel free to offer any ideas here or in a new issue as it's something that would greatly improve the quality of this action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants