Skip to content

Conversation

@tyrsson
Copy link
Owner

@tyrsson tyrsson commented Aug 17, 2025

No description provided.

Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
Signed-off-by: Joey Smith <jsmith@webinertia.net>
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson tyrsson added this to the 0.1.0 milestone Aug 17, 2025
Copilot AI review requested due to automatic review settings August 17, 2025 03:56

This comment was marked as outdated.

Bump phpstan to level 10
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
…continue after the CommandHandlerMiddleware processes the command.

Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
Adds
CommandHandlerFactory
CommandHandlerFactoryFactory
Several Exception classes
---
Code cleanup
Stubs Laminas ServiceManager factories and Psr ContainerInterface

Signed-off-by: Joey Smith <jsmith@webinertia.net>
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson tyrsson self-assigned this Aug 18, 2025
@tyrsson tyrsson added enhancement New feature or request phpstan Static Analysis priority: high labels Aug 18, 2025
@tyrsson tyrsson requested a review from Copilot August 18, 2025 10:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the codebase from Psalm to PHPStan for static analysis, updates namespace organization, and enhances error handling in the command bus middleware pipeline. The changes provide better type safety and more structured exception handling.

Key changes:

  • Replaced Psalm configuration and type annotations with PHPStan equivalents
  • Reorganized the namespace from PhpCmd to PhpCmd\CmdBus for better structure
  • Enhanced exception handling with specific exception types for different error scenarios

Reviewed Changes

Copilot reviewed 38 out of 40 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/unit/NextTest.php Added comprehensive test suite for the Next class middleware handler
test/unit/CmdBusTest.php Updated namespace and imports to align with new structure
test/integration/TestAssets/*.php Added test middleware classes and updated namespaces for integration testing
test/integration/CmdBusTest.php Enhanced integration tests with middleware pipeline testing and namespace updates
stubs/*.stub Added PHPStan stub files for external dependencies (Laminas ServiceManager, PSR Container)
src/Next.php Enhanced error handling with specific exceptions and improved middleware processing
src/Exception/*.php Added specific exception classes for better error categorization
src/Container/*.php Updated factories with proper type annotations and namespace alignment
src/*.php Updated core classes with namespace changes and improved type safety
phpstan.neon.dist Added PHPStan configuration replacing Psalm
composer.json Updated dependencies and autoloading for PHPStan migration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson tyrsson merged commit 40b7820 into tyrsson:0.1.x Aug 18, 2025
10 checks passed
@tyrsson tyrsson deleted the phpstan branch August 18, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request phpstan Static Analysis priority: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant