Adds missing test #19
Conversation
Signed-off-by: Joey Smith <jsmith@webinertia.net> Signed-off-by: Joey Smith <jsmith@webinertia.net>
tyrsson
added
enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests for the MiddlewarePipe class, providing test coverage for a command bus middleware pipeline implementation. The tests cover interface compliance, pipeline functionality, middleware execution order, and various edge cases.
- Adds complete test suite for
MiddlewarePipeclass with 20 test methods - Tests middleware pipeline operations including adding middleware, handling commands, and processing through the pipeline
- Validates proper execution order, cloning behavior, and support for various return types
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| $middleware1 = new class ($executionOrder) implements MiddlewareInterface { | ||
| /** @param array<string> $executionOrder */ | ||
| public function __construct( | ||
| /** @phpstan-ignore property.onlyWritten */ |
There was a problem hiding this comment.
The PHPStan ignore comment is incorrect - the property is being read in the process method on line 177. This suppression should be removed as it's suppressing a non-existent issue.
| /** @phpstan-ignore property.onlyWritten */ |
| /** @param array<string> $executionOrder */ | ||
| public function __construct( | ||
| /** @phpstan-ignore property.onlyWritten */ | ||
| private array &$executionOrder |
There was a problem hiding this comment.
The PHPStan ignore comment is incorrect - the property is being read in the process method on line 192. This suppression should be removed as it's suppressing a non-existent issue.
| private array &$executionOrder | |
| private array &$executionOrder |
1 participant
No description provided.