Skip to content

Commit 0d183f3

Browse files
committed
changes in default transport factory
- set null transport if empty - throw exception in neither dsn nor alias are set.
1 parent f490077 commit 0d183f3

File tree

2 files changed

+1
-32
lines changed

2 files changed

+1
-32
lines changed

DependencyInjection/EnqueueExtension.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,6 @@ public function addTransportFactory(TransportFactoryInterface $transportFactory)
5252
*/
5353
public function load(array $configs, ContainerBuilder $container)
5454
{
55-
// enable null transport by default.
56-
array_unshift($configs, [
57-
'transport' => [
58-
'default' => 'null://',
59-
],
60-
]);
61-
6255
$config = $this->processConfiguration(new Configuration($this->factories), $configs);
6356

6457
$loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));

Tests/Unit/DependencyInjection/EnqueueExtensionTest.php

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
use Enqueue\Client\TraceableProducer;
1010
use Enqueue\Null\NullContext;
1111
use Enqueue\Null\Symfony\NullTransportFactory;
12-
use Enqueue\Symfony\TransportFactoryInterface;
1312
use Enqueue\Symfony\DefaultTransportFactory;
13+
use Enqueue\Symfony\TransportFactoryInterface;
1414
use Enqueue\Test\ClassExtensionTrait;
1515
use PHPUnit\Framework\TestCase;
1616
use Symfony\Component\DependencyInjection\ContainerBuilder;
@@ -116,30 +116,6 @@ public function testShouldUseNullTransportAsDefaultWhenExplicitlyConfigured()
116116
);
117117
}
118118

119-
public function testShouldUseNullTransportAsDefaultConfiguredViaDSN()
120-
{
121-
$container = new ContainerBuilder();
122-
123-
$extension = new EnqueueExtension();
124-
$extension->addTransportFactory(new NullTransportFactory());
125-
$extension->addTransportFactory(new DefaultTransportFactory());
126-
127-
$extension->load([[
128-
'transport' => [
129-
'default' => 'null://',
130-
],
131-
]], $container);
132-
133-
self::assertEquals(
134-
'enqueue.transport.default.context',
135-
(string) $container->getAlias('enqueue.transport.context')
136-
);
137-
self::assertEquals(
138-
'enqueue.transport.default_null.context',
139-
(string) $container->getAlias('enqueue.transport.default.context')
140-
);
141-
}
142-
143119
public function testShouldConfigureFooTransport()
144120
{
145121
$container = new ContainerBuilder();

0 commit comments

Comments
 (0)