Skip to content

CHANGE: don't set if-modified-since header when discover feeds #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

CHANGE: don't set if-modified-since header when discover feeds #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Add logic to set the node's link from the <guid> element when isPermaLink="true" and no link is present. (#12)
- Do no longer default to 1800-01-01 as date for fetching feeds (#15)
- don't set if-modified-since header when discover feeds (#19)

### Fixed
- Analysis of relative links for the Atom feed (#10)
2 changes: 1 addition & 1 deletion src/FeedIo/Explorer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function __construct(
public function discover(string $url): array
{
$this->logger->info("discover feeds from {$url}");
$stream = $this->client->getResponse($url, new DateTime('@0'));
$stream = $this->client->getResponse($url, null);

$internalErrors = libxml_use_internal_errors(true);
$feeds = $this->extractFeeds($stream->getBody(), $url);
Expand Down