Skip to content

Conversation

@Grotax
Copy link

@Grotax Grotax commented Sep 11, 2025

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where RSS/Atom feed links containing linebreaks or whitespace cause malformed URLs. The fix adds trim() calls to strip whitespace from link values before processing them.

  • Strip whitespace from RSS link element values using trim()
  • Strip whitespace from Atom link href attributes using trim()
  • Add comprehensive test coverage for both whitespace handling and relative URL processing

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
src/FeedIo/Rule/Link.php Trims whitespace from RSS link element values
src/FeedIo/Rule/Atom/Link.php Trims whitespace from Atom link href attributes
tests/FeedIo/Rule/LinkTest.php Adds test cases for whitespace handling and relative URL processing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Grotax Grotax merged commit a8e6b4e into main Sep 15, 2025
5 checks passed
@Grotax Grotax deleted the fix/Link branch September 15, 2025 07:21
Grotax added a commit that referenced this pull request Sep 29, 2025
- Trim whitespace from URLs in Link properties and add tests for whitespace handling and relative URLs (#26)
- bin/feedio was not working anymore (#25)
@Grotax Grotax mentioned this pull request Sep 29, 2025
Grotax added a commit that referenced this pull request Sep 29, 2025
- Trim whitespace from URLs in Link properties and add tests for whitespace handling and relative URLs (#26)
- bin/feedio was not working anymore (#25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant