Skip to content

Conversation

@Grotax
Copy link

@Grotax Grotax commented Jun 29, 2025

Since I am planning to take PRs from the original repo that target 5.3.x I added unit tests to this branch to, separated file to manage different php versions, other options where too complicated.

Also added devcontiner to support local dev and test.

And unit tests found a small issue, not sure why that was not already fixed, maybe because tests did not run like this.

@Grotax Grotax requested review from SMillerDev and Copilot June 29, 2025 10:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces unit test workflows for the release/5.3.x branch, updates composer metadata, and adds development container support.

  • Added a new GitHub Actions workflow for unit tests with a PHP version matrix
  • Updated composer.json details including project name, homepage, and author information
  • Introduced devcontainer configuration and Dockerfile for local development, while removing an outdated CI workflow

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/FeedIo/Feed/Node.php Added a null check before calling explode() on the link value
composer.json Updated project name, homepage, and added an additional author
.github/workflows/unit-tests.yml Created a new workflow file for unit tests with a PHP matrix
.github/workflows/ci.yml Removed the old CI workflow
.github/FUNDING.yml Removed funding information for alexdebril
.devcontainer/php.ini Added custom PHP settings for development
.devcontainer/devcontainer.json Introduced a devcontainer configuration with VS Code customizations
.devcontainer/Dockerfile Added a Dockerfile for the devcontainer environment

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Grotax Grotax merged commit cfe966c into release/5.3.x Jun 29, 2025
4 checks passed
@Grotax Grotax deleted the actions/5.3.x branch June 29, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants