Only work with the request target, not the line #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @evert notes, by allowing specifying the entire request line, we have the possibility that it goes out of sync with the request method and protocol version, which would lead to an inconsistent and invalid message.
|
@pmjones Ready to merge. When you do, please tag as 0.8.0, with the message "Reference request-target only, not the request line". Thanks! |
pmjones
pushed a commit
that referenced
this pull request
Jan 28, 2015
Only work with the request target, not the line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @evert notes, by allowing specifying the entire request line, we have the possibility that it goes out of sync with the request method and protocol version, which would lead to an inconsistent and invalid message.
This patch syncs with the patch in php-fig/fig-standards#414, and should be merged after it has been; additionally, this repo should then be tagged as 0.8.0.