Blade Extractor cache path cannot be null with laravel-framework: 5.2.41

[Solinx]

Gettext: 3.6.0
laravel-framework: 5.2.41

After upgrading from laravel-framework 5.2.39 to 5.2.41 the Blade extractor caused an InvalidArgumentException related to the cache path of the BladeCompiler. The cause is that after this upgrade the base Compiler provided by Laravel checks whether a truthy cache path is provided as second argument. The Blade extractor creates a BladeCompiler with NULL as cache path.

I figure changing NULL into true would do the trick, as the Blade extractor does not appear to use cache anyway and there do not appear to be any negative consequences in the Compiler class.

Cheers,
Wouter van Dam

[oscarotero]

As I can see here the cachePath cannot be empty, and should be a string (according to phpdocs). Maybe other solution is use sys_get_temp_dir, but I'm not entirely familiar with Laravel. Blade extractor was developed by @eusonlito so I'd like to know his opinion.

[eusonlito]

Compile path is setup using $app['config']['view.compiled'] and required from 18 july illuminate/view@0428197

I think that is safe to set sys_get_temp_dir as function parameter instead null.

Some Laravel code isn't adapted yet to this new parameter requirement.

[oscarotero]

Ok, this is in 5.2-dev so it's not stable yet and may be changed in a future.
So I've commited a patch to 3.x and 4.x but wont be tagged until the next stable release of illuminate/view.

[cmoralesweb]

@oscarotero It is released already: https://laraver.xyz/projects/Laravel/versions/v5.2.40 (and it looks like it got also into 5.1.41)

[cmoralesweb]

@oscarotero @eusonlito Why not use that configuration instead of the temp dir?

$compilePath = \Config::get('view.compiled'); $bladeCompiler = new BladeCompiler(new Filesystem(), $compilePath);

[oscarotero]

Using Config inside this library introduce a new dependency that I'd like to avoid. The sys_get_temp_dir solution is used only if no other path has been provided (here's the patch, but you can use Config outside of the library:

Gettext 3.x:

Gettext\Extractors\Blade::$cachePath = Config::get('view.compiled');
$translations = Translations::fromBladeFile('template.blade.php');

Gettext 4.x:

$translations = Translations::fromBladeFile('template.blade.php', [
    'cachePath' => Config::get('view.compiled')
]);

[oscarotero]

3.6.1 and 4.0.1 released including a path for this.