Update dependencies and update to reflect new PHP Parser changes.#16
Merged
oscarotero merged 4 commits intophp-gettext:masterfrom Mar 10, 2024
BusterNeece:master
Merged
Update dependencies and update to reflect new PHP Parser changes.#16oscarotero merged 4 commits intophp-gettext:masterfrom BusterNeece:master
oscarotero merged 4 commits intophp-gettext:masterfrom
BusterNeece:master
Conversation
oscarotero
requested changes
Mar 9, 2024
Member
oscarotero
left a comment
There was a problem hiding this comment.
Thanks!
I just left a couple of comments to fix a bug regarding numeric arguments.
Contributor
Author
|
@oscarotero Issues with numeric args should be fixed now. I initially couldn't tell what was causing that, but it turns out it was a simple problem with a simple fix. |
Contributor
Author
|
@oscarotero Just pushed an update that should fix the GitHub Actions, setting them to run from 7.4 up, and downgrading PHPUnit to the latest stable version that supports that far back. You could certainly set the minimum PHP requirement higher, but I wanted to have as few BC breaks as possible in the PR. |
oscarotero
approved these changes
Mar 10, 2024
Member
|
Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the following:
composer.jsonto depend onnikic/php-parserversion 5.x instead of 4.x