Replace xml with php config #484
Merged
+459
−313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orest-Divintari
force-pushed
the
orest/replace-xml-with-php-config
branch
2 times, most recently
from
153c95d to
dbab283
Compare
Convert all service configuration files from deprecated XML format to PHP format to eliminate Symfony deprecation warnings and for Symfony 8.0 compatibility.
Orest-Divintari
force-pushed
the
orest/replace-xml-with-php-config
branch
from
dbab283 to
8b1d3fe
Compare
dbu
approved these changes
Dec 9, 2025
Collaborator
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
thanks a lot, this looks good, and the tests agree.
why did you mark it as draft? are you trying it out in some real application?
Contributor
Author
Thanks, No, it was late at night and wanted to review it myself before I ask you to review it. |
ruudk
approved these changes
Dec 9, 2025
Contributor
|
@dbu Thanks for the quick merge! Would you mind tagging it ? 🙏 |
Collaborator
|
i'd love to include sf 8 support in the release. but #483 fails with weird errors - if you have any inputs/ideas what could be the issue, i'd love inputs as i don't have any more ideas what it could be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
It replaces xml config with php config.
Why?
Because Symfony 7.4 has deprecated xml config
Checklist