Add acquire timeout support to PostgreSQLMutex #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemanator
force-pushed
the
support_postgresql_timeout
branch
from
0204814 to
a9f8890
Compare
mvorisek
reviewed
Jul 8, 2025
colemanator
force-pushed
the
support_postgresql_timeout
branch
from
4143853 to
7ee091e
Compare
|
@mvorisek just following up on this one, please let me know if you need anything else. |
|
Please allow me to edit your PR branch: 
PR looks good, I have prepared small CS modifications I want to push and merge then. |
|
Done, had to transfer the fork out of our org for the option to become available. |
|
The coverage discovered there is no test for the lock acquired. Please add E2E test. To |
|
Do you want two mutex factories in |
mvorisek
changed the title
|
Yes and thank you, great contribution ❤ |
|
@mvorisek thanks for making it happen 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #66
Add support for timeouts to PostgresSQLMutex, as mentioned in this issue #66 PostgreSQL supports a non-blocking advisory lock function.
We've needed this a few times and previously I've rolled our own lock/mutex but it'd be easier if it was in the package. Happy to work through any feedback on this one, tried to follow existing patterns, if I missed anything let me know.