Normalize stdClass to array in Request::fromArray() for param type sa… #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fety Converts stdClass to an associative array when decoding 'params' in JsonRpc\Request, ensuring type compliance with downstream DTOs. Fixes php-mcp/server#53 See php-mcp/server#53 (comment)
Fixes runtime issue where 'arguments' could be a stdClass when omitted or sent as {}.
Casts to array and defaults to [] to ensure strict constructor contract.
Related to php-mcp/server#53
|
Going ahead to merge this one in. Thanks a lot for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two commits:
Request::fromArray()to ensureparamsis always array or nullargumentsinCallToolRequest::fromRequest()by defaulting to [] and casting stdClass to arrayTogether, these fixes eliminate the root cause of php-mcp/server#53,
which caused type errors when clients omitted 'arguments' or sent an empty object
{}.Fixes php-mcp/server#53
See php-mcp/server#53 (comment)