Batching requests (send them concurrently)

[mamciek]

GuzzlePHP allows to send requests concurrently (using curl_multi_exec). How can it be implemented in riak-client? I am willing to work on that.
http://docs.guzzlephp.org/en/latest/clients.html#batching-requests

Can it be implemented by adding metod batch(array $riakCommands) to Riak\Client\RiakClient (and to all internally called interfaces) ?

[FabioBatSilva]

Hi @mamciek

Not all Riak commands make sense to be done concurrently,
It would have to be implemented specific of each command.

Fetch value is probably the one that makes more sense to start with, see java implementation

You would have to implement :

• MultiFetch Command
• MultiFetch Operation
• MultiFetch{Request,Response} Message
• MultiFetch Http Transport

Let me know if you need help.

[mamciek]

Thanks.

Fetching KV and Datatypes certainly makes sense to be done concurrently. What about updating/storing values in Riak? It does make sense in my opinion. I think it even makes sense to batch together request of different type, for example fetchKV, fetchDataType, UpdateMap and so on.

[FabioBatSilva]

Indeed the most common use would be fetching,

I'd like to keep the batch command base,
dealing with different response types might be complicated.

We might have something like :

/** @var $multiFetch Kv\MultiFetchCommand*/
/** @var $response FetchValueResponse[] */
$result = $client->execute($multiFetch);


/** @var $multiFetchCounter DataTyoe\MultiFetchCounterCommand*/
/** @var $counterResult FetchCounterResponse[] */
$counterResult = $client->execute($multiFetchCounter);

In this case all the response objects share the same response type,
$response can either be a FetchValueResponse array or a collection/iterator

[mamciek]

In the meantime I created simple prototype: #7
It deals only with FetchMap, but you can get the vision. With this approach I would be able to batch multiple type of commands. What do you think ?

[FabioBatSilva]

Cool,

We can discuss more on #7 now..