Skip to content

Conversation

@IanDelMar
Copy link
Contributor

Uses szepeviktor/phpcs-psr-12-neutron-hybrid-ruleset

A first round of fixes. I will do some more, but feel free to merge any time Viktor.

@szepeviktor
Copy link
Member

szepeviktor commented Oct 25, 2023

Noooooooooooooooooooooo! This is not a proper project.
Proper projects have all their bytes checked in each commit.
https://github.com/szepeviktor/byte-level-care/tree/master/.github/workflows

I let you send any kind of PR.

@szepeviktor
Copy link
Member

szepeviktor commented Oct 25, 2023

Proper projects should have an src/ visitor/ directory and a lot of other stuff.
https://github.com/szepeviktor/github-repository-inspection

@szepeviktor
Copy link
Member

We could make this package very nice.
The first step could be to remove all traces of WordPress 🙃

@IanDelMar
Copy link
Contributor Author

should have an visitor/ directory

Strongly agree!

@szepeviktor
Copy link
Member

szepeviktor commented Oct 26, 2023

Strongly agree!

With each class in its own file and a tiny (return new X();) visitor.php

@IanDelMar
Copy link
Contributor Author

Would love that. I set up a branch like this to fiddle around with the voids and nevers.

@szepeviktor szepeviktor merged commit a4a4a4c into php-stubs:6.4 Oct 30, 2023
@IanDelMar IanDelMar deleted the cs branch November 2, 2023 23:57
@IanDelMar IanDelMar mentioned this pull request Nov 4, 2023
IanDelMar added a commit to IanDelMar/wordpress-stubs that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants