Skip to content

Fix and improve handling of wp_die's 3rd parameter #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szepeviktor merged 1 commit into from
Oct 28, 2023
Merged

Fix and improve handling of wp_die's 3rd parameter #123

szepeviktor merged 1 commit into from
Oct 28, 2023

Conversation

@IanDelMar
Copy link
Contributor

@IanDelMar IanDelMar commented Oct 28, 2023 •
edited
Loading

  • Fixes incorrect handling of wp_die's return type when 'exit' is not set (Cherry pick #121 onto 6.4 #122 (comment)).
  • Adds check for integer argument.
  • Uses PhpParser\ConstExprEvaluator to check the 3rd parameter which increases accuracy and readability.

@szepeviktor
Copy link
Member

szepeviktor commented Oct 28, 2023

Thank you!
Now it is less complex.

@szepeviktor szepeviktor merged commit 07aa8ce into php-stubs:6.4 Oct 28, 2023
@IanDelMar IanDelMar deleted the die-wp-die branch October 28, 2023 19:27
IanDelMar added a commit to IanDelMar/wordpress-stubs that referenced this pull request Nov 8, 2023
@IanDelMar
Fix and improve handling of wp_die's 3rd parameter (php-stubs#123)
903d7e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IanDelMar @szepeviktor