executeCommand with inlinekeyboard

[datrix88]

Hi guys, thanks for this awesome API for Telegram BOT.

I have a problem when i try to execute a command in CallbackqueryCommand class.
When i click on Inline button nothing is happening.

It's very strange because if i use executeCommand function on my other own command, it works fine.

This is my code:

//StartCommand

[....]

$inline_keyboard = [
            new InlineKeyboardButton(['text' => "Add Category", 'callback_data' => 'add']),
            new InlineKeyboardButton(['text' => "Help", 'callback_data' => 'help'])
];

$data = [
            'chat_id' => $chat_id,
            'text' => $text,
            'reply_markup' => new InlineKeyboardMarkup(['inline_keyboard' => [$inline_keyboard]]),
            'parse_mode' => "MARKDOWN"
];

[....]

//CallBackQueryCommand

[....]

$update = $this->getUpdate();
$callback_query = $update->getCallbackQuery();
$callback_query_id = $callback_query->getId();
$callback_data = $callback_query->getData();
$data['callback_query_id'] = $callback_query_id;

if ($this->getTelegram()->getCommandObject($callback_data)){
      return $this->getTelegram()->executeCommand($callback_data);
}

[....]

How I can resolve this problem?
Thanks in advance!

[MBoretto]

probably $callback_data is wrong

[datrix88]

Hi @MBoretto, thanks for your help.

$callback_data is correct, "if condition" works if i return sendMessage function inside it.

I don't know what to do to resolve this problem :(

[noplanman]

The problem here is the Update object, since it's a callback_query instead of a message.
I've been trying to get this to work and have found a very ugly solution, but it works so far.
Give this a spin and let me know what you think.

Remember, this is a hack and I haven't thoroughly tested it, just in a private chat with the bot!

(P.S. Your StartCommand looks fine 👍)

// CallbackqueryCommand.php
public function execute()
{
    $callback_query    = $this->getUpdate()->getCallbackQuery();
    $callback_query_id = $callback_query->getId();
    $callback_data     = $callback_query->getData();

    if ($cmdobj = $this->getTelegram()->getCommandObject($callback_data)) {
        // Get the message array.
        $new_message_array = json_decode($callback_query->getMessage()->toJson(), true);

        // Override from so that it looks like we're the ones who sent the message.
        $new_message_array['from'] = $new_message_array['chat'];

        $new_update = new Update(
            ['update_id' => '-1', 'message' => $new_message_array],
            $callback_query->getBotName()
        );
        $cmdobj->setUpdate($new_update)->preExecute();
    }

    return Request::answerCallbackQuery(['callback_query_id' => $callback_query_id]);
}

[datrix88]

Oh My God, finally works! :D

Need to add "use Longman\TelegramBot\Entities\Update;" between libraries, I write it so that it can help those who had the same problem.

Thanks a lot @noplanman, you are best :)

[noplanman]

You're welcome. Just keep in mind that this probably isn't the most elegant solution, so if Telegram change something in the bot functionality, this may break.

But until then, enjoy 😃

[phuongdev89]

@noplanman save my life

[CaliforniaMountainSnake]

For everyone who want to execute a command from callbackquery:

class MyTelegram extends Telegram {
    /**
     * @param string        $_command The bot command.
     * @param string        $_text    The text which will be sent to the command.
     * @param CallbackQuery $_callback_query
     *
     * @return ServerResponse|null
     * @throws TelegramException
     */
    public function executeCommandFromCallbackquery(
        string $_command,
        string $_text,
        CallbackQuery $_callback_query
    ): ?ServerResponse {
        // In a callback_query "message->from" entity will have the bot itself data.
        // So, we need to copy userId from the "callback_query->from" entity.
        // A conversation will be started with the bot itself, if we don't change "message->from" value.
        return $this->executeCommandWithText($_command, $_text,
            $_callback_query->getMessage(), $_callback_query->getFrom());
    }

    /**
     * @param string    $_command
     * @param string    $_text
     * @param Message   $_message
     * @param User|null $_from
     *
     * @return ServerResponse|null
     * @throws TelegramException
     */
    public function executeCommandWithText(
        string $_command,
        string $_text,
        Message $_message,
        ?User $_from = null
    ): ?ServerResponse {
        /** @var Update $update */
        $update = $this->update;
        $rawUpdate = json_decode($update->toJson(), true);
        if (($jsonError = json_last_error()) !== JSON_ERROR_NONE) {
            $this->getInlineMenuLogger()->error('Update json decoding error: "' . $jsonError . '"');
            $this->getInlineMenuLogger()->debug('Update raw data', $rawUpdate);
        }

        $rawUpdate['message'] = $_message->getRawData();
        $rawUpdate['message']['text'] = $_text;

        if ($_from !== null) {
            $rawUpdate['message']['from'] = $_from->getRawData();
        }

        return $this->executeCommandWithUpdate($_command, $rawUpdate);
    }

    /**
     * @param string $_command
     * @param array  $_raw_update
     *
     * @return ServerResponse|null Command response or null if this command does not exist.
     * @throws TelegramException
     * @see https://github.com/php-telegram-bot/core/issues/485#issuecomment-298847941
     * @see https://github.com/php-telegram-bot/core/issues/532#issuecomment-446393767
     */
    public function executeCommandWithUpdate(string $_command, array $_raw_update): ?ServerResponse
    {
        $placeholderCommandObject = $this->getCommandObject($_command);
        if ($placeholderCommandObject === null) {
            $this->getInlineMenuLogger()->error('Command "' . $_command . '" does not exist!');
            return null;
        }
        $commandClass = get_class($placeholderCommandObject);

        /** @var Command $commandObject */
        $commandObject = new $commandClass($this, new Update($_raw_update));
        return $commandObject->preExecute();
    }
}

See: my library trait

[noplanman]

Thanks for sharing your method @CaliforniaMountainSnake!