Skip to content

Conversation

z38
Copy link
Contributor

@z38 z38 commented Jul 24, 2017

When the tests run in an environment which is not in UTC timezone, one test case fails because the timezone is not set explicitly.

Copy link
Contributor

@yukoff yukoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukoff yukoff merged commit 49896c9 into php-tmdb:2.1 Jul 24, 2017
@yukoff
Copy link
Contributor

yukoff commented Jul 24, 2017

Next time please make sure you use LF for newlines. I'll add .editorconfig

@z38 z38 deleted the fix-utc branch July 24, 2017 21:20
@z38
Copy link
Contributor Author

z38 commented Jul 24, 2017

Thanks for merging 👍 It seems that ReleaseDate.php and ReleaseDateTest.php are the only files with CRLF line terminators.

@yukoff
Copy link
Contributor

yukoff commented Jul 24, 2017

I've fixed that already, I'll see how it's in #148

@yukoff
Copy link
Contributor

yukoff commented Jul 24, 2017

And thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants