Skip to content

Conversation

@rvanlaak
Copy link
Member

@rvanlaak rvanlaak commented Feb 3, 2022

No description provided.

@rvanlaak
Copy link
Member Author

rvanlaak commented Feb 3, 2022

@Nyholm config seems blocking, given that other test runs are marked as required.

@rvanlaak
Copy link
Member Author

rvanlaak commented Feb 3, 2022

cc @bocharsky-bw

@bocharsky-bw
Copy link
Member

Yeah, I can handle that blocked (required) jobs...

@bocharsky-bw
Copy link
Member

Could you rebase master here to fix conflicts?

@rvanlaak
Copy link
Member Author

rvanlaak commented Feb 3, 2022

@bocharsky-bw conflict resolved. Please squash the PRs once merging.

@rvanlaak
Copy link
Member Author

rvanlaak commented Feb 4, 2022

@bocharsky-bw ready for review again

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@bocharsky-bw bocharsky-bw merged commit 9eb078c into php-translation:master Feb 4, 2022
@rvanlaak rvanlaak deleted the patch-1 branch February 4, 2022 15:46
@bocharsky-bw
Copy link
Member

It just occurred to me that we probably should do the same in 3.x branch as well, I created a PR: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants