Skip to content

Call to trans with variable must not trigger Exception #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2020
Merged

Call to trans with variable must not trigger Exception #147

merged 1 commit into from
Jan 18, 2020

Conversation

@axi
Copy link
Contributor

@axi axi commented Jan 13, 2020

9070899 introduced strict string on BaseVisitor addLocation method, calls to trans($myVar) should not be added.

Nyholm
Nyholm approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit c5d58cf into php-translation:master Jan 18, 2020
@Guite Guite mentioned this pull request Jan 19, 2020
Closed
@nicwortel nicwortel mentioned this pull request Jan 24, 2020
Closed
@tkleinhakisa tkleinhakisa mentioned this pull request Jan 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@axi @Nyholm