Skip to content

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented Apr 11, 2018

The extractor already require twig/twig. We are referencing @twig here and here

Is it wrong of us to require the bundle?

@Nyholm Nyholm requested review from bocharsky-bw and rvanlaak April 11, 2018 13:23
Copy link
Member

@rvanlaak rvanlaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requiring twig-bundle is fine by me. Probably the bundle at the moment already doesn't work without Twig anymore.

@Nyholm
Copy link
Member Author

Nyholm commented Apr 11, 2018

Probably the bundle at the moment already doesn't work without Twig anymore.

True

@Nyholm Nyholm merged commit da6bb44 into master Apr 11, 2018
@Nyholm Nyholm deleted the patch-2 branch April 11, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants