Skip to content

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 26, 2018

It takes too much time to see code coverage on the functional tests. PHPUnit has to keep track on all the Symfony stack.

@Nyholm
Copy link
Member Author

Nyholm commented Jun 26, 2018

This will bring back the build to green

@Nyholm Nyholm merged commit c9c04e1 into master Jun 26, 2018
@Nyholm Nyholm deleted the patch-execution-time branch June 26, 2018 12:53
Copy link
Member

@rvanlaak rvanlaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍 Functional tests should not get covered, as that also means the coverage includes everything the container does.

@Nyholm
Copy link
Member Author

Nyholm commented Jun 26, 2018

Yeah, a cheap trick to improve the test coverage. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants