[Js] Fix registering custom elements #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
welcoMattic
approved these changes
Jul 18, 2019
Member
|
@Lctrs good catch! Thanks for contributing @bocharsky-bw I think we can merge this one, as tests are green |
bocharsky-bw
approved these changes
Jul 19, 2019
Member
bocharsky-bw
left a comment
bocharsky-bw
left a comment
There was a problem hiding this comment.
Agree, changes look good to me too 👍
Member
|
Thank you for this fix and the review, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document.registerElement()doesn't exist anymore at least in Firefox. According to MDN Documentation, it has been replaced bycustomElements.define().Close #270