Skip to content

Conversation

@Guite
Copy link
Contributor

@Guite Guite commented Jan 13, 2020

This fixes the problem that catalogues are read from the "main" translation directory when extracting messages only for a specific bundle. The effect of this change is that messages from the main configuration are not entirely copied into the bundle being processed.

The second commit fixes another problem: when using the YAML format it may happen that the initial translation is null instead of an empty string. The createMessage() method expects a string argument though.

@rvanlaak rvanlaak requested a review from Nyholm January 14, 2020 08:11
@odolbeau
Copy link
Member

Hi @Guite & thanks for your first contribution! 🎉

Could you please split your PR?
I would like to approve your first commit but the second one is not enough to solve the problem you have as the createMessage method won't accept a null argument.

Copy link
Member

@odolbeau odolbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR to split

@Guite
Copy link
Contributor Author

Guite commented Jan 14, 2020

as the createMessage method won't accept a null argument

This is exactly the problem; hence my fix changes it to a string.

@odolbeau
Copy link
Member

as the createMessage method won't accept a null argument

This is exactly the problem; hence my fix changes it to a string.

Oups! :o
In this case, that's perfect, thanks a lot! 👍

@odolbeau odolbeau merged commit fb560bb into php-translation:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants