Skip to content

Improve rendering to support dark mode #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

Improve rendering to support dark mode #386

merged 1 commit into from
Jan 15, 2020

Conversation

@odolbeau
Copy link
Member

@odolbeau odolbeau commented Jan 15, 2020

Fix #384

Dark mode:
image

Light mode:
image

rvanlaak
rvanlaak approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@rvanlaak rvanlaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

welcoMattic
welcoMattic approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@welcoMattic welcoMattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🖤

@welcoMattic welcoMattic merged commit 0810fbe into php-translation:master Jan 15, 2020
@welcoMattic welcoMattic mentioned this pull request Jan 17, 2020
Merged
@Nyholm
Copy link
Member

Nyholm commented Jan 18, 2020

Yes! Thank you <3

@odolbeau odolbeau deleted the dark-mode branch February 10, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@welcoMattic welcoMattic welcoMattic approved these changes

@rvanlaak rvanlaak rvanlaak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dark mode support

4 participants

@odolbeau @Nyholm @welcoMattic @rvanlaak