Skip to content

Fix psalm issues #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 26, 2021
Merged

Fix psalm issues #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc993a1
Typecast ->request->get() value to string
bocharsky-bw Mar 26, 2021
911c109
Fix PHP CS Fixer issue
bocharsky-bw Mar 26, 2021
9162bc8
Fix other psalm issues
bocharsky-bw Mar 26, 2021
6d8382a
Fix PHP CS Fixer issues one more time
bocharsky-bw Mar 26, 2021
54e1254
Try to fix PhpStan issue
bocharsky-bw Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Controller/SymfonyProfilerController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function editAction(Request $request, string $token): Response
}

//Assert: This is a POST request
$message->setTranslation($request->request->get('translation'));
$message->setTranslation((string) $request->request->get('translation'));
$this->storage->update($message->convertToMessage());

return new Response($message->getTranslation());
Expand Down Expand Up @@ -125,7 +125,7 @@ private function getMessage(Request $request, string $token): SfProfilerMessage
{
$this->profiler->disable();

$messageId = $request->request->get('message_id', $request->query->get('message_id'));
$messageId = (string) $request->request->get('message_id', $request->query->get('message_id'));

$collectorMessages = $this->getMessages($token);

Expand Down Expand Up @@ -154,8 +154,9 @@ protected function getSelectedMessages(Request $request, string $token): array
{
$this->profiler->disable();

$selected = $request->request->get('selected');
if (!$selected || 0 == \count($selected)) {
/** @var string[] $selected */
$selected = (array) $request->request->get('selected');
if (0 === \count($selected)) {
return [];
}

Expand Down
5 changes: 0 additions & 5 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ parameters:
count: 1
path: Command/StatusCommand.php

-
message: "#^Call to an undefined static method Symfony\\\\Component\\\\Intl\\\\Intl\\:\\:getLocaleBundle\\(\\)\\.$#"
count: 1
path: Controller/WebUIController.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\TreeBuilder\\:\\:root\\(\\)\\.$#"
count: 1
Expand Down