Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit 21b62c4

Browse files
committed
Update chagnelog
1 parent a4c9e62 commit 21b62c4

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
This project versioning adheres to [Semantic Versioning](http://semver.org/).
33

44
## Unreleased
5+
### Added
6+
- Connection and request timeouts could be specified also when creating RemoteWebDriver from existing session ID.
57

68
## 1.5.0 - 2017-11-15
79
### Changed

lib/Remote/RemoteWebDriver.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ protected function __construct(
8585
* @param int|null $connection_timeout_in_ms Set timeout for the connect phase to remote Selenium WebDriver server
8686
* @param int|null $request_timeout_in_ms Set the maximum time of a request to remote Selenium WebDriver server
8787
* @param string|null $http_proxy The proxy to tunnel requests to the remote Selenium WebDriver through
88-
* @param int|null $http_proxy_port The proxy port to tunnel requests to the remote Selenium WebDriver through
88+
* @param int|null $http_proxy_port The proxy port to tunnel requests to the remote Selenium WebDriver through
8989
* @param DesiredCapabilities $required_capabilities The required capabilities
9090
* @return RemoteWebDriver
9191
*/
@@ -143,9 +143,12 @@ public static function create(
143143
* @param int|null $request_timeout_in_ms Set the maximum time of a request to remote Selenium WebDriver server
144144
* @return RemoteWebDriver
145145
*/
146-
public static function createBySessionID($session_id, $selenium_server_url = 'http://localhost:4444/wd/hub', $connection_timeout_in_ms = null, $request_timeout_in_ms = null)
147-
{
148-
146+
public static function createBySessionID(
147+
$session_id,
148+
$selenium_server_url = 'http://localhost:4444/wd/hub',
149+
$connection_timeout_in_ms = null,
150+
$request_timeout_in_ms = null
151+
) {
149152
$executor = new HttpCommandExecutor($selenium_server_url);
150153
if ($connection_timeout_in_ms !== null) {
151154
$executor->setConnectionTimeout($connection_timeout_in_ms);

0 commit comments

Comments
 (0)