Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit 9482a3e

Browse files
authored
Merge pull request #456 from OndraM/feature/drop-php-5.5
Drop PHP 5.5 support
2 parents 1c5e7f0 + cb1f8bd commit 9482a3e

File tree

5 files changed

+9
-10
lines changed

5 files changed

+9
-10
lines changed

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ sudo: false
33
dist: trusty
44

55
php:
6-
- 5.5
76
- 5.6
87
- 7.0
98
- 7.1

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
This project versioning adheres to [Semantic Versioning](http://semver.org/).
33

44
## Unreleased
5+
### Changed
6+
- Drop PHP 5.5 support, the minimal required version of PHP is now PHP 5.6.
57

68
## 1.4.1 - 2017-04-28
79
### Fixed

lib/Support/Events/EventFiringWebDriver.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -396,15 +396,14 @@ protected function newElement(WebDriverElement $element)
396396

397397
/**
398398
* @param mixed $method
399+
* @param mixed $arguments,...
399400
*/
400-
protected function dispatch($method)
401+
protected function dispatch($method, ...$arguments)
401402
{
402403
if (!$this->dispatcher) {
403404
return;
404405
}
405406

406-
$arguments = func_get_args();
407-
unset($arguments[0]);
408407
$this->dispatcher->dispatch($method, $arguments);
409408
}
410409

lib/Support/Events/EventFiringWebDriverNavigation.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,15 +149,14 @@ public function to($url)
149149

150150
/**
151151
* @param mixed $method
152+
* @param mixed $arguments,...
152153
*/
153-
protected function dispatch($method)
154+
protected function dispatch($method, ...$arguments)
154155
{
155156
if (!$this->dispatcher) {
156157
return;
157158
}
158159

159-
$arguments = func_get_args();
160-
unset($arguments[0]);
161160
$this->dispatcher->dispatch($method, $arguments);
162161
}
163162

lib/Support/Events/EventFiringWebElement.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -392,14 +392,14 @@ protected function dispatchOnException(WebDriverException $exception)
392392

393393
/**
394394
* @param mixed $method
395+
* @param mixed $arguments,...
395396
*/
396-
protected function dispatch($method)
397+
protected function dispatch($method, ...$arguments)
397398
{
398399
if (!$this->dispatcher) {
399400
return;
400401
}
401-
$arguments = func_get_args();
402-
unset($arguments[0]);
402+
403403
$this->dispatcher->dispatch($method, $arguments);
404404
}
405405

0 commit comments

Comments
 (0)