Use PHPStan for static analysis

Author: OndraM

.travis.yml

@@ -70,7 +70,10 @@ matrix:
     - php: 7.1
       env: CHECK_CODESTYLE=1
       before_script: ~
-      script: composer codestyle:check
+      script:
+        - composer require phpstan/phpstan-shim # Not part of require-dev, because it won't install on PHP 5.6
+        - composer analyze
+        - composer codestyle:check
       after_script: ~
       after_success: ~
 

composer.json

@@ -45,6 +45,9 @@
     "codestyle:fix": [
       "vendor/bin/php-cs-fixer fix --diff || exit 0",
       "vendor/bin/phpcbf --standard=PSR2 ./lib/ ./tests/"
+    ],
+    "analyze": [
+      "vendor/bin/phpstan.phar analyze ./lib ./tests --level 2 -c phpstan.neon --ansi"
     ]
   },
   "extra": {

lib/Firefox/FirefoxProfile.php

@@ -110,7 +110,7 @@ public function setPreference($key, $value)
     }
 
     /**
-     * @param $key
+     * @param mixed $key
      * @return mixed
      */
     public function getPreference($key)

lib/Support/Events/EventFiringWebDriver.php

@@ -133,7 +133,7 @@ public function findElement(WebDriverBy $by)
     }
 
     /**
-     * @param       $script
+     * @param string $script
      * @param array $arguments
      * @throws WebDriverException
      * @return mixed
@@ -161,7 +161,7 @@ public function executeScript($script, array $arguments = [])
     }
 
     /**
-     * @param       $script
+     * @param string $script
      * @param array $arguments
      * @throws WebDriverException
      * @return mixed
@@ -396,7 +396,7 @@ protected function newElement(WebDriverElement $element)
 
     /**
      * @param mixed $method
-     * @param mixed $arguments,...
+     * @param mixed ...$arguments
      */
     protected function dispatch($method, ...$arguments)
     {

lib/Support/Events/EventFiringWebDriverNavigation.php

@@ -149,7 +149,7 @@ public function to($url)
 
     /**
      * @param mixed $method
-     * @param mixed $arguments,...
+     * @param mixed ...$arguments
      */
     protected function dispatch($method, ...$arguments)
     {

lib/Support/Events/EventFiringWebElement.php

@@ -392,7 +392,7 @@ protected function dispatchOnException(WebDriverException $exception)
 
     /**
      * @param mixed $method
-     * @param mixed $arguments,...
+     * @param mixed ...$arguments
      */
     protected function dispatch($method, ...$arguments)
     {

lib/WebDriverExpectedCondition.php

@@ -213,7 +213,7 @@ function (WebDriver $driver) use ($by) {
                         if ($element->isDisplayed()) {
                             $visibleElements[] = $element;
                         }
-                    } catch (StateElementReferenceException $e) {
+                    } catch (StaleElementReferenceException $e) {
                     }
                 }
 
@@ -399,7 +399,7 @@ function (WebDriver $driver) use ($by) {
     /**
      * An expectation for checking that an element with text is either invisible or not present on the DOM.
      *
-     * @param WebdriverBy $by The locator used to find the element.
+     * @param WebDriverBy $by The locator used to find the element.
      * @param string $text The text of the element.
      * @return WebDriverExpectedCondition<bool> Condition returns whether the text is found in the element located.
      */

lib/WebDriverHasInputDevices.php

@@ -21,7 +21,7 @@
 interface WebDriverHasInputDevices
 {
     /**
-     * @return WebDriverKeyBoard
+     * @return WebDriverKeyboard
      */
     public function getKeyboard();
 

phpstan.neon

@@ -0,0 +1,10 @@
+parameters:
+	ignoreErrors:
+		- '#Class Symfony\\Component\\Process\\ProcessBuilder not found.#'
+		- '#Instantiated class Symfony\\Component\\Process\\ProcessBuilder not found.#'
+		- '#Call to method setPrefix\(\) on an unknown class Symfony\\Component\\Process\\ProcessBuilder#'
+        # To be fixed:
+		- '#Call to an undefined method RecursiveIteratorIterator::getSubPathName\(\)#'
+		- '#Call to an undefined method Facebook\\WebDriver\\WebDriver::getTouch\(\)#'
+		- '#Call to an undefined method Facebook\\WebDriver\\WebDriverElement::getCoordinates\(\)#'
+		- '#Call to an undefined method Facebook\\WebDriver\\WebDriverElement::equals\(\)#'

tests/functional/WebDriverByTest.php

@@ -25,8 +25,8 @@ class WebDriverByTest extends WebDriverTestCase
 {
     /**
      * @dataProvider textElementsProvider
-     * @param $webDriverByLocatorMethod
-     * @param $webDriverByLocatorValue
+     * @param string $webDriverByLocatorMethod
+     * @param string $webDriverByLocatorValue
      * @param string $expectedText
      * @param string $expectedAttributeValue
      */