Ds interfaces are documented as classes

[AndrolGenhald]

https://www.php.net/manual/en/class.ds-collection.php
https://www.php.net/manual/en/class.ds-hashable.php
https://www.php.net/manual/en/class.ds-sequence.php

Both the URLs and the Interface synopses incorrectly indicate that these are classes (although it appears other interface URLs also say class, so maybe part is intentional?).

[cmb69]

The class. prefix in the URL is intentional (classes and interface live in the same namespace anyway).

But, yeah, the markup for the interfaces is broken (and also interfaces are supposed to extend other interfaces, not to implement them).

[mallardduck]

@cmb69 - I don't know enough about phd and the few hours I've been playing with it have been fruitless.

However, from the XML side of things I quickly found that this is valid and gets closer to what we'd desire here:

    <classsynopsisinfo>

     <oointerface>
      <interfacename>Ds\Collection</interfacename>
     </oointerface>

     <oointerface>
      <modifier>extends</modifier>
      <interfacename>Traversable</interfacename>
     </oointerface>

     <oointerface>
      <interfacename>Countable</interfacename>
     </oointerface>

     <oointerface>
      <interfacename>JsonSerializable</interfacename>
     </oointerface>

    </classsynopsisinfo>

The issue is that phd still renders the initial implements rather than only rendering extends. So this is the end result:

[cmb69]

@mallardduck, yeah, this isn't properly solveable with current PhD. gen_stub.php would generate the following:

    <classsynopsisinfo>

     <oointerface>
      <interfacename>Ds\Collection</interfacename>
     </oointerface>

     <ooclass>
      <modifier>extends</modifier>
      <classname>Traversable</classname>
     </ooclass>
     <ooclass>
      <classname>Countable</classname>
     </ooclass>
     <ooclass>
      <classname>JsonSerializable</classname>
     </ooclass>

    </classsynopsisinfo>

This results in:

So, besides the markup is not quite correct, the commas between the interface names are missing.

We need to fix PhD in this regard. We also should check docgen, and it may make sense to add a skeleton for interfaces.

[mallardduck]

Wasn't exactly sure the best place to start, so I just decided to pick the parts that are most familiar to me currently. I figure that's the best way to make sense out of these new things I'm coming across.

As such I've started by making a PR for the interface skeleton: php/doc-base#61

[Girgias]

Fixed via #2549