Various amendements to follow-up on GH-4936 #4980
Merged
+211
−205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllenJB
reviewed
Nov 4, 2025
reference/pdo/constants.xml
Outdated
Comment on lines
631
to
632
| This is usually know if when examining the return code from the method | ||
| that raised the error condition anyway. |
Contributor
There was a problem hiding this comment.
This is usually known by examining the return code from the method
that raised the error condition anyway.
Contributor
|
@Girgias One minor issue. Other than that looks fine to me. 👍 I'll keep these in mind as I make future contributions. |
kamil-tekiela
approved these changes
Nov 4, 2025
Member
kamil-tekiela
left a comment
kamil-tekiela
left a comment
There was a problem hiding this comment.
Apart from that one thing AllenJB mentioned, it looks good. I even prefer it that this is done as a separate PR because it's easier to review.
Girgias
force-pushed
the
pdo-fetch-follow-up
branch
from
2e7afe6 to
2ff5759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #4936 as I have various manual style guide and markup complaints with the new (and existing) docs.
@AllenJB please review as the original author. :)