Skip to content

Conversation

@Crell
Copy link
Contributor

@Crell Crell commented Jun 14, 2021

I'm not sure this is structured properly. I can restructure to some other format if someone tells me what the format should be. :-)

@morrisonlevi
Copy link
Contributor

Maybe add a note on visibility of the __invoke method?

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Crell
Copy link
Contributor Author

Crell commented Jun 14, 2021

Revised.

@Crell Crell changed the title Fold in comments from the site. Fold in comments from is_callable() page Jun 15, 2021
@cmb69
Copy link
Member

cmb69 commented Jun 17, 2021

@Girgias, what do you think about the layout of the notes section? It's rather different from what we usually use (i.e. multiple <note>s and such), but I think I like this better.

@Girgias
Copy link
Member

Girgias commented Jun 17, 2021

The layout might make more sense then what we currently have at times, so it's all green on my end. :-)

@cmb69 cmb69 merged commit 4807f1a into php:master Jun 17, 2021
Copy link
Contributor

@salathe salathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some post-merge comments. Poor effort from the code reviewers on this one. 😛

cmb69 added a commit that referenced this pull request Jun 18, 2021
@cmb69
Copy link
Member

cmb69 commented Jun 18, 2021

Thank you, @salathe! Fixed as 83a17a7.

@Crell Crell deleted the is-callable branch June 18, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants