-
Notifications
You must be signed in to change notification settings - Fork 12
Improve README, link unbundle RFC #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be completely outdated, since there have been no PECL releases for almost 20 years. Are there any plans regarding a new release? At least the RFC about unbundling pdo_oci states:
/cc @derickr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll get to it when I next have time; I will merge the test PR as is, and do some testing, and do a release.
Lack of PECL releases was not specific to PDO_OCI. E.g https://pecl.php.net/package/pdo, https://pecl.php.net/package/pdo_mysql both haven't had releases. Back in the day it was decided (or became true) that there was a tight coupling between the vendor layer and the generic layer, and no releases were made on PECL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, PDO and pdo_mysql are still bundled with php-src, so there is no need to have new releases. But since pdo_oci has been unbundled, it would make sense to re-activate the PECL page. At least for Windows users that would be helpful, to be able to download pre-built DLLs.
I'll try to come up with a PR regarding building (and testing) on CI (for Windows).