Use "must not" instead of "cannot" wording

Author: Girgias

Zend/tests/property_hooks/invalid_empty_hooks.phpt

@@ -1,5 +1,5 @@
 --TEST--
-Property hook list cannot be empty
+Property hook list must not be empty
 --FILE--
 <?php
 
@@ -9,4 +9,4 @@ class Test {
 
 ?>
 --EXPECTF--
-Fatal error: Property hook list cannot be empty in %s on line %d
+Fatal error: Property hook list must not be empty in %s on line %d

Zend/zend_API.c

@@ -439,9 +439,9 @@ ZEND_API ZEND_COLD void zend_argument_value_error(uint32_t arg_num, const char *
 }
 /* }}} */
 
-ZEND_API ZEND_COLD void zend_argument_cannot_be_empty_error(uint32_t arg_num)
+ZEND_API ZEND_COLD void zend_argument_must_not_be_empty_error(uint32_t arg_num)
 {
-	zend_argument_value_error(arg_num, "cannot be empty");
+	zend_argument_value_error(arg_num, "must not be empty");
 }
 
 ZEND_API ZEND_COLD void zend_class_redeclaration_error_ex(int type, zend_string *new_name, zend_class_entry *old_ce)

Zend/zend_API.h

@@ -1564,7 +1564,7 @@ ZEND_API ZEND_COLD void ZEND_FASTCALL zend_argument_error_variadic(zend_class_en
 ZEND_API ZEND_COLD void zend_argument_error(zend_class_entry *error_ce, uint32_t arg_num, const char *format, ...);
 ZEND_API ZEND_COLD void zend_argument_type_error(uint32_t arg_num, const char *format, ...);
 ZEND_API ZEND_COLD void zend_argument_value_error(uint32_t arg_num, const char *format, ...);
-ZEND_API ZEND_COLD void zend_argument_cannot_be_empty_error(uint32_t arg_num);
+ZEND_API ZEND_COLD void zend_argument_must_not_be_empty_error(uint32_t arg_num);
 ZEND_API ZEND_COLD void zend_class_redeclaration_error(int type, zend_class_entry *old_ce);
 ZEND_API ZEND_COLD void zend_class_redeclaration_error_ex(int type, zend_string *new_name, zend_class_entry *old_ce);
 

Zend/zend_compile.c

@@ -8390,7 +8390,7 @@ static void zend_compile_property_hooks(
 	}
 
 	if (hooks->children == 0) {
-		zend_error_noreturn(E_COMPILE_ERROR, "Property hook list cannot be empty");
+		zend_error_noreturn(E_COMPILE_ERROR, "Property hook list must not be empty");
 	}
 
 	for (uint32_t i = 0; i < hooks->children; i++) {

ext/bz2/bz2.c

@@ -349,7 +349,7 @@ PHP_FUNCTION(bzopen)
 	/* If it's not a resource its a string containing the filename to open */
 	if (Z_TYPE_P(file) == IS_STRING) {
 		if (Z_STRLEN_P(file) == 0) {
-			zend_argument_cannot_be_empty_error(1);
+			zend_argument_must_not_be_empty_error(1);
 			RETURN_THROWS();
 		}
 

ext/bz2/tests/001.phpt

@@ -42,8 +42,8 @@ var_dump(bzopen($fp, "r"));
 
 ?>
 --EXPECTF--
-bzopen(): Argument #1 ($file) cannot be empty
-bzopen(): Argument #1 ($file) cannot be empty
+bzopen(): Argument #1 ($file) must not be empty
+bzopen(): Argument #1 ($file) must not be empty
 bzopen(): Argument #2 ($mode) must be either "r" or "w"
 bzopen(): Argument #2 ($mode) must be either "r" or "w"
 bzopen(): Argument #2 ($mode) must be either "r" or "w"

ext/dba/dba.c

@@ -547,15 +547,15 @@ static void php_dba_open(INTERNAL_FUNCTION_PARAMETERS, bool persistent)
 	}
 
 	if (ZSTR_LEN(path) == 0) {
-		zend_argument_cannot_be_empty_error(1);
+		zend_argument_must_not_be_empty_error(1);
 		RETURN_THROWS();
 	}
 	if (ZSTR_LEN(mode) == 0) {
-		zend_argument_cannot_be_empty_error(2);
+		zend_argument_must_not_be_empty_error(2);
 		RETURN_THROWS();
 	}
 	if (handler_str && ZSTR_LEN(handler_str) == 0) {
-		zend_argument_cannot_be_empty_error(3);
+		zend_argument_must_not_be_empty_error(3);
 		RETURN_THROWS();
 	}
 	// TODO Check Value for permission

ext/dba/tests/value_errors_open.phpt

@@ -121,9 +121,9 @@ object(Dba\Connection)#%d (%d) {
 
 Warning: dba_open(): Handler "bogus" is not available in %s on line %d
 bool(false)
-dba_open(): Argument #1 ($path) cannot be empty
-dba_open(): Argument #2 ($mode) cannot be empty
-dba_open(): Argument #3 ($handler) cannot be empty
+dba_open(): Argument #1 ($path) must not be empty
+dba_open(): Argument #2 ($mode) must not be empty
+dba_open(): Argument #3 ($handler) must not be empty
 dba_open(): Argument #2 ($mode) first character must be one of "r", "w", "c", or "n"
 dba_open(): Argument #2 ($mode) second character must be one of "d", "l", "-", or "t"
 dba_open(): Argument #2 ($mode) third character must be "t"
@@ -133,9 +133,9 @@ dba_open(): Argument #5 ($map_size) must be greater than or equal to 0
 
 Warning: dba_popen(): Handler "bogus" is not available in %s on line %d
 bool(false)
-dba_popen(): Argument #1 ($path) cannot be empty
-dba_popen(): Argument #2 ($mode) cannot be empty
-dba_popen(): Argument #3 ($handler) cannot be empty
+dba_popen(): Argument #1 ($path) must not be empty
+dba_popen(): Argument #2 ($mode) must not be empty
+dba_popen(): Argument #3 ($handler) must not be empty
 dba_popen(): Argument #2 ($mode) first character must be one of "r", "w", "c", or "n"
 dba_popen(): Argument #2 ($mode) second character must be one of "d", "l", "-", or "t"
 dba_popen(): Argument #2 ($mode) third character must be "t"

ext/dom/document.c

@@ -1525,7 +1525,7 @@ static void dom_parse_document(INTERNAL_FUNCTION_PARAMETERS, int mode)
 	}
 
 	if (!source_len) {
-		zend_argument_cannot_be_empty_error(1);
+		zend_argument_must_not_be_empty_error(1);
 		RETURN_THROWS();
 	}
 	if (ZEND_SIZE_T_INT_OVFL(source_len)) {
@@ -1579,7 +1579,7 @@ PHP_METHOD(DOMDocument, save)
 	}
 
 	if (file_len == 0) {
-		zend_argument_cannot_be_empty_error(1);
+		zend_argument_must_not_be_empty_error(1);
 		RETURN_THROWS();
 	}
 
@@ -1883,7 +1883,7 @@ static void dom_document_schema_validate(INTERNAL_FUNCTION_PARAMETERS, int type)
 	}
 
 	if (!source_len) {
-		zend_argument_cannot_be_empty_error(1);
+		zend_argument_must_not_be_empty_error(1);
 		RETURN_THROWS();
 	}
 
@@ -1992,7 +1992,7 @@ static void dom_document_relaxNG_validate(INTERNAL_FUNCTION_PARAMETERS, int type
 	}
 
 	if (!source_len) {
-		zend_argument_cannot_be_empty_error(1);
+		zend_argument_must_not_be_empty_error(1);
 		RETURN_THROWS();
 	}
 
@@ -2085,7 +2085,7 @@ static void dom_load_html(INTERNAL_FUNCTION_PARAMETERS, int mode) /* {{{ */
 	}
 
 	if (!source_len) {
-		zend_argument_cannot_be_empty_error(1);
+		zend_argument_must_not_be_empty_error(1);
 		RETURN_THROWS();
 	}
 
@@ -2162,7 +2162,7 @@ PHP_METHOD(DOMDocument, saveHTMLFile)
 	}
 
 	if (file_len == 0) {
-		zend_argument_cannot_be_empty_error(1);
+		zend_argument_must_not_be_empty_error(1);
 		RETURN_THROWS();
 	}
 

ext/dom/domimplementation.c

@@ -64,7 +64,7 @@ PHP_METHOD(DOMImplementation, createDocumentType)
 	}
 
 	if (name_len == 0) {
-		zend_argument_cannot_be_empty_error(1);
+		zend_argument_must_not_be_empty_error(1);
 		RETURN_THROWS();
 	}