Skip to content

Commit b8fc6bd

Browse files
ndosschendossche
committed
Fix GH-21097: Accessing Dom\Node properties can can throw TypeError(s)
Split the handler again, or defer to instanceof when performance doesn't matter. Closes GH-21108.
1 parent 1dfc802 commit b8fc6bd

File tree

7 files changed

+77
-5
lines changed

7 files changed

+77
-5
lines changed

‎NEWS‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ PHP NEWS
1616
- DOM:
1717
. Fixed bug GH-21077 (Accessing Dom\Node::baseURI can throw TypeError).
1818
(ndossche)
19+
. Fixed bug GH-21097 (Accessing Dom\Node properties can can throw TypeError).
20+
(ndossche)
1921

2022
- PDO_PGSQL:
2123
. Fixed bug GH-21055 (connection attribute status typo for GSS negotiation).

‎ext/dom/documenttype.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ zend_result dom_documenttype_entities_read(dom_object *obj, zval *retval)
4747
{
4848
DOM_PROP_NODE(xmlDtdPtr, dtdptr, obj);
4949

50-
php_dom_create_iterator(retval, DOM_DTD_NAMEDNODEMAP, php_dom_follow_spec_intern(obj));
50+
php_dom_create_iterator(retval, DOM_DTD_NAMEDNODEMAP, instanceof_function(obj->std.ce, dom_modern_documenttype_class_entry));
5151

5252
xmlHashTable *entityht = (xmlHashTable *) dtdptr->entities;
5353

@@ -68,7 +68,7 @@ zend_result dom_documenttype_notations_read(dom_object *obj, zval *retval)
6868
{
6969
DOM_PROP_NODE(xmlDtdPtr, dtdptr, obj);
7070

71-
php_dom_create_iterator(retval, DOM_DTD_NAMEDNODEMAP, php_dom_follow_spec_intern(obj));
71+
php_dom_create_iterator(retval, DOM_DTD_NAMEDNODEMAP, instanceof_function(obj->std.ce, dom_modern_documenttype_class_entry));
7272

7373
xmlHashTable *notationht = (xmlHashTable *) dtdptr->notations;
7474

‎ext/dom/dom_properties.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ zend_result dom_entity_version_read(dom_object *obj, zval *retval);
102102
zend_result dom_entity_reference_child_read(dom_object *obj, zval *retval);
103103
zend_result dom_entity_reference_text_content_read(dom_object *obj, zval *retval);
104104
zend_result dom_entity_reference_child_nodes_read(dom_object *obj, zval *retval);
105+
zend_result dom_modern_entity_reference_child_nodes_read(dom_object *obj, zval *retval);
105106

106107
/* namednodemap properties */
107108
zend_result dom_namednodemap_length_read(dom_object *obj, zval *retval);
@@ -119,6 +120,7 @@ zend_result dom_node_node_type_read(dom_object *obj, zval *retval);
119120
zend_result dom_node_parent_node_read(dom_object *obj, zval *retval);
120121
zend_result dom_node_parent_element_read(dom_object *obj, zval *retval);
121122
zend_result dom_node_child_nodes_read(dom_object *obj, zval *retval);
123+
zend_result dom_modern_node_child_nodes_read(dom_object *obj, zval *retval);
122124
zend_result dom_node_first_child_read(dom_object *obj, zval *retval);
123125
zend_result dom_node_last_child_read(dom_object *obj, zval *retval);
124126
zend_result dom_node_previous_sibling_read(dom_object *obj, zval *retval);

‎ext/dom/entityreference.c‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,4 +106,12 @@ zend_result dom_entity_reference_child_nodes_read(dom_object *obj, zval *retval)
106106
return dom_node_child_nodes_read(obj, retval);
107107
}
108108

109+
zend_result dom_modern_entity_reference_child_nodes_read(dom_object *obj, zval *retval)
110+
{
111+
DOM_PROP_NODE(xmlNodePtr, nodep, obj);
112+
113+
dom_entity_reference_fetch_and_sync_declaration(nodep);
114+
return dom_modern_node_child_nodes_read(obj, retval);
115+
}
116+
109117
#endif

‎ext/dom/node.c‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,18 @@ zend_result dom_node_child_nodes_read(dom_object *obj, zval *retval)
287287
{
288288
DOM_PROP_NODE(xmlNodePtr, nodep, obj);
289289

290-
php_dom_create_iterator(retval, DOM_NODELIST, php_dom_follow_spec_intern(obj));
290+
php_dom_create_iterator(retval, DOM_NODELIST, false);
291+
dom_object *intern = Z_DOMOBJ_P(retval);
292+
dom_namednode_iter(obj, XML_ELEMENT_NODE, intern, NULL, NULL, 0, NULL, 0);
293+
294+
return SUCCESS;
295+
}
296+
297+
zend_result dom_modern_node_child_nodes_read(dom_object *obj, zval *retval)
298+
{
299+
DOM_PROP_NODE(xmlNodePtr, nodep, obj);
300+
301+
php_dom_create_iterator(retval, DOM_NODELIST, true);
291302
dom_object *intern = Z_DOMOBJ_P(retval);
292303
dom_namednode_iter(obj, XML_ELEMENT_NODE, intern, NULL, NULL, 0, NULL, 0);
293304

‎ext/dom/php_dom.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -897,7 +897,7 @@ PHP_MINIT_FUNCTION(dom)
897897
DOM_REGISTER_PROP_HANDLER(&dom_modern_node_prop_handlers, "ownerDocument", dom_node_owner_document_read, NULL);
898898
DOM_REGISTER_PROP_HANDLER(&dom_modern_node_prop_handlers, "parentNode", dom_node_parent_node_read, NULL);
899899
DOM_REGISTER_PROP_HANDLER(&dom_modern_node_prop_handlers, "parentElement", dom_node_parent_element_read, NULL);
900-
DOM_REGISTER_PROP_HANDLER(&dom_modern_node_prop_handlers, "childNodes", dom_node_child_nodes_read, NULL);
900+
DOM_REGISTER_PROP_HANDLER(&dom_modern_node_prop_handlers, "childNodes", dom_modern_node_child_nodes_read, NULL);
901901
DOM_REGISTER_PROP_HANDLER(&dom_modern_node_prop_handlers, "firstChild", dom_node_first_child_read, NULL);
902902
DOM_REGISTER_PROP_HANDLER(&dom_modern_node_prop_handlers, "lastChild", dom_node_last_child_read, NULL);
903903
DOM_REGISTER_PROP_HANDLER(&dom_modern_node_prop_handlers, "previousSibling", dom_node_previous_sibling_read, NULL);
@@ -1294,7 +1294,7 @@ PHP_MINIT_FUNCTION(dom)
12941294
DOM_OVERWRITE_PROP_HANDLER(&dom_modern_entity_reference_prop_handlers, "firstChild", dom_entity_reference_child_read, NULL);
12951295
DOM_OVERWRITE_PROP_HANDLER(&dom_modern_entity_reference_prop_handlers, "lastChild", dom_entity_reference_child_read, NULL);
12961296
DOM_OVERWRITE_PROP_HANDLER(&dom_modern_entity_reference_prop_handlers, "textContent", dom_entity_reference_text_content_read, NULL);
1297-
DOM_OVERWRITE_PROP_HANDLER(&dom_modern_entity_reference_prop_handlers, "childNodes", dom_entity_reference_child_nodes_read, NULL);
1297+
DOM_OVERWRITE_PROP_HANDLER(&dom_modern_entity_reference_prop_handlers, "childNodes", dom_modern_entity_reference_child_nodes_read, NULL);
12981298
zend_hash_add_new_ptr(&classes, dom_modern_entityreference_class_entry->name, &dom_modern_entity_reference_prop_handlers);
12991299

13001300
dom_processinginstruction_class_entry = register_class_DOMProcessingInstruction(dom_node_class_entry);

‎ext/dom/tests/modern/common/gh21097.phpt‎

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
--TEST--
2+
GH-21097 (Accessing Dom\Node properties can can throw TypeError(s))
3+
--EXTENSIONS--
4+
dom
5+
--CREDITS--
6+
mbeccati
7+
--FILE--
8+
<?php
9+
10+
$implementation = new \Dom\Implementation();
11+
$node = $implementation->createDocumentType('html', 'publicId', 'systemId');
12+
13+
$r = new \ReflectionClass($node);
14+
foreach ($r->getProperties(\ReflectionProperty::IS_PUBLIC) as $p) {
15+
echo $p->getName(), ": ";
16+
var_dump($node->{$p->getName()});
17+
}
18+
19+
?>
20+
--EXPECT--
21+
nodeType: int(10)
22+
nodeName: string(4) "html"
23+
baseURI: string(11) "about:blank"
24+
isConnected: bool(false)
25+
ownerDocument: NULL
26+
parentNode: NULL
27+
parentElement: NULL
28+
childNodes: object(Dom\NodeList)#24 (1) {
29+
["length"]=>
30+
int(0)
31+
}
32+
firstChild: NULL
33+
lastChild: NULL
34+
previousSibling: NULL
35+
nextSibling: NULL
36+
nodeValue: NULL
37+
textContent: string(0) ""
38+
name: string(4) "html"
39+
entities: object(Dom\DtdNamedNodeMap)#24 (1) {
40+
["length"]=>
41+
int(0)
42+
}
43+
notations: object(Dom\DtdNamedNodeMap)#24 (1) {
44+
["length"]=>
45+
int(0)
46+
}
47+
publicId: string(8) "publicId"
48+
systemId: string(8) "systemId"
49+
internalSubset: NULL

0 commit comments

Comments
 (0)