dom: Fix compile warning due to misplaced const cast

ndossche · iluuu1994 · commit bd67ba66a892 · 2025-12-02T16:59:51.000+01:00
diff --git a/ext/dom/document.c b/ext/dom/document.c
@@ -1120,7 +1120,7 @@ PHP_METHOD(DOMDocument, __construct)
 	}
 
 	if (encoding_len > 0) {
-		docp->encoding = (const xmlChar *) xmlStrdup((xmlChar *) encoding);
+		docp->encoding = xmlStrdup((const xmlChar *) encoding);
 	}
 
 	intern = Z_DOMOBJ_P(ZEND_THIS);

Original file line number	Diff line number	Diff line change
`@@ -1120,7 +1120,7 @@ PHP_METHOD(DOMDocument, __construct)`
`1120`	`1120`	`}`
`1121`	`1121`
`1122`	`1122`	`if (encoding_len > 0) {`
`1123`		`- docp->encoding = (const xmlChar ) xmlStrdup((xmlChar ) encoding);`
	`1123`	`+ docp->encoding = xmlStrdup((const xmlChar *) encoding);`
`1124`	`1124`	`}`
`1125`	`1125`
`1126`	`1126`	`intern = Z_DOMOBJ_P(ZEND_THIS);`