ext/dom: Fix [-Wsign-compare] warnings

Girgias · Girgias · commit f52a332d5a03 · 2024-06-06T16:18:23.000+01:00
diff --git a/ext/dom/characterdata.c b/ext/dom/characterdata.c
@@ -135,7 +135,7 @@ PHP_METHOD(DOMCharacterData, substringData)
 		RETURN_FALSE;
 	}
 
-	if (offset > length) {
+	if (offset > (unsigned int)length) {
 		php_dom_throw_error(INDEX_SIZE_ERR, dom_get_strict_error(intern->document));
 		RETURN_FALSE;
 	}
@@ -230,7 +230,7 @@ static void dom_character_data_insert_data(INTERNAL_FUNCTION_PARAMETERS, bool re
 		RETURN_FALSE;
 	}
 
-	if (offset > length) {
+	if (offset > (unsigned int)length) {
 		php_dom_throw_error(INDEX_SIZE_ERR, dom_get_strict_error(intern->document));
 		RETURN_FALSE;
 	}

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ PHP_METHOD(DOMCharacterData, substringData)`
`135`	`135`	`RETURN_FALSE;`
`136`	`136`	`}`
`137`	`137`
`138`		`- if (offset > length) {`
	`138`	`+ if (offset > (unsigned int)length) {`
`139`	`139`	`php_dom_throw_error(INDEX_SIZE_ERR, dom_get_strict_error(intern->document));`
`140`	`140`	`RETURN_FALSE;`
`141`	`141`	`}`
`@@ -230,7 +230,7 @@ static void dom_character_data_insert_data(INTERNAL_FUNCTION_PARAMETERS, bool re`
`230`	`230`	`RETURN_FALSE;`
`231`	`231`	`}`
`232`	`232`
`233`		`- if (offset > length) {`
	`233`	`+ if (offset > (unsigned int)length) {`
`234`	`234`	`php_dom_throw_error(INDEX_SIZE_ERR, dom_get_strict_error(intern->document));`
`235`	`235`	`RETURN_FALSE;`
`236`	`236`	`}`