Fix GH-14590: Memory leak in FPM test gh13563-conf-bool-env.phpt#14708
Closed
ndossche wants to merge 1 commit intophp:PHP-8.2from
Closed
Fix GH-14590: Memory leak in FPM test gh13563-conf-bool-env.phpt#14708ndossche wants to merge 1 commit intophp:PHP-8.2from
ndossche wants to merge 1 commit intophp:PHP-8.2from
Conversation
Values retrieved from zend_getenv should be freed.
Member
|
Quick (genuine) question, if it depends on the actual sapi, do all callbacks use zend alloc api consistently for every case (and platforms) ? |
Member
Author
|
The only possible value for |
Member
|
Makes sense thx. |
devnexen
approved these changes
Jun 28, 2024
Contributor
|
Thank you for fixing it! Why can't you take a minimal test case from the bug report? Example without correct OUTPUT: master...jorgsowa:php-src:bug-gh-14590-test-case |
Member
Author
|
@jorgsowa I suppose we can, I didn't do it because it would tie the test to fpm although the issue is not related to fpm at all. Feel free to submit that as a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is not related to FPM. Values retrieved from zend_getenv should be freed.
Making a test is not trivial because the CLI sapi doesn't implement the sapi getenv hook, so zend_getenv always returns NULL.