Fix some -Wimplicit-function-declaration errors on Windows#15325
Merged
cmb69 merged 1 commit intophp:masterfrom Aug 10, 2024
Merged
Fix some -Wimplicit-function-declaration errors on Windows#15325cmb69 merged 1 commit intophp:masterfrom
cmb69 merged 1 commit intophp:masterfrom
Conversation
While clang is picky about these, MSVC doesn't seem to care and would only report the calls to undeclared functions as errors during link time. Still, obviously, MSVC is fine with having the declarations during compile time.
ndossche
approved these changes
Aug 10, 2024
bukka
approved these changes
Aug 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While clang is picky about these, MSVC doesn't seem to care and would only report the calls to undeclared functions as errors during link time. Still, obviously, MSVC is fine with having the declarations during compile time.
Note that these fixes all such errors for a full build of all self-contained extensions (i.e. those which don't require external libraries), except for ext/com_dotnet (which throws link errors), and the undeclared
_AddressOfReturnAddress()in zend_call_stack.h which is due to 36857ab (need to figure out what that is about).