Only benchmark master #12092
Only benchmark master #12092
Conversation
|
Hmm, actually. Benchmarking older branches may still be useful for patch PRs. The main reason I created this PR is to avoid mixed benchmarks in https://nielsdos.github.io/php-benchmark-visualisation/. I guess we could solve that by including the branch in the JSON. |
|
@nielsdos Do you think a branch property in the JSON would be a proper solution? Do you have anything else in mind? |
|
@iluuu1994 I thought first that we could figure it out at the visualisation repo by reading commit metadata, but now I think having that data available is easier. I think a field could work, but what could also work is having multiple branches over at the benchmark-data repo. E.g. all benchmark results of PHP-8.3 in php-src get commited to branch PHP-8.3 in the benchmark repo data. Similarly for the master branch. |
|
@nielsdos I think I'd prefer a branch property, if you're ok with that. Having different branches would also complicate comparison against the base branch. I.e. we'd need to make sure we checkout the correct benchmark data branch for a PR target branch. |
|
Closing in favor of #12101. |
No description provided.