Skip to content

Include branch in benchmarking information #12101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

This allows https://nielsdos.github.io/php-benchmark-visualisation/ to only show commits from master (or a specific branch). Otherwise we get confusing, undulating commits from different branches, with potentially wildly different performance.

@iluuu1994 iluuu1994 mentioned this pull request Sep 1, 2023
@nielsdos
Copy link
Member

nielsdos commented Sep 1, 2023

This field approach is fine for me.
The output seems wrong though, it includes stdout and stderr subfields and HEAD was not replaced with the right branch.

@iluuu1994
Copy link
Member Author

I forgot to use the stdout prop. I'm not sure why the output is HEAD, it's probably because the GitHub checkout action checks out the commit instead of the branch. I might have to use the env variable then.

@iluuu1994 iluuu1994 force-pushed the benchmarking-add-branch branch from 606d06b to 1357273 Compare September 2, 2023 21:19
This allows https://nielsdos.github.io/php-benchmark-visualisation/ to only
show commits from master (or a specific branch). Otherwise we get confusing,
undulating commits from different branches, with potentially wildly different
performance.
@iluuu1994 iluuu1994 force-pushed the benchmarking-add-branch branch from 1357273 to 73fd4cd Compare September 2, 2023 23:46
@iluuu1994 iluuu1994 requested a review from TimWolla as a code owner September 2, 2023 23:46
@staabm
Copy link
Contributor

staabm commented Sep 3, 2023

https://nielsdos.github.io/php-benchmark-visualisation/

i wonder why the graph is climbing over time.. doesnt it mean the instruction count is getting bigger and bigger and therefore php-src slower and slower?

@iluuu1994
Copy link
Member Author

@staabm The first big spike is not a real performance drop. See 4ca8daf#commitcomment-111688104. Other than that, it's been pretty stable. The recent spike is caused by 766cac0, Jakub said that he will investigate this when he has the time.

The are fluctuations in the measurements that I haven't yet found the cause of. It would be nice if it was more stable, so it would be easier to point out the exact commit that causes a performance drop.

@iluuu1994 iluuu1994 closed this in ee6f9e2 Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants