Skip to content

Fix test expectation for "Built by..." #15383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix test expectation for "Built by..." #15383

merged 1 commit into from
Aug 13, 2024

Conversation

@remicollet
Copy link
Member

@remicollet remicollet commented Aug 13, 2024

Following afc5738

ping @NattyNarwhal @bukka

@remicollet remicollet requested a review from bukka as a code owner August 13, 2024 15:00
@remicollet
Copy link
Member Author

remicollet commented Aug 13, 2024

Test failing with

     string(%d) "PHP %s (fpm%s (built: %s
     Copyright (c) The PHP Group
003+ Built by Remi's RPM repository <https://rpms.remirepo.net/> #StandWithUkraine
     Zend Engine v%s, Copyright (c) Zend Technologies
     "
     Done

NattyNarwhal
NattyNarwhal approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@NattyNarwhal NattyNarwhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry I forgot about this one.

@Girgias Girgias merged commit 40d88ca into php:master Aug 13, 2024
@remicollet remicollet deleted the issue-buildertest branch August 14, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NattyNarwhal NattyNarwhal NattyNarwhal approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees

No one assigned

Labels

SAPI: fpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@remicollet @NattyNarwhal @Girgias